Brading Software :: Brading Software Message Board Website Forums

Brading Software Message Board » Mp3/Tag Studio » Mp3/Tag Studio Support and Bug Reports » need help using simple macro

[ Track this topic :: Email this topic :: Print this topic ]

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 24 2004,06:11 I just downloaded the new version and am jumping right in!! Thanks for all the great new features!! So, I created a very simple macro, like this: 1. open macro window 2. click "Record new macro" - recording starts 3. while in the "Auto tag (from filename)" tab, with the following things set:    3a. appropriate format selected    3b. case fix checked with the appropriate preset selected    3c. Replace checkbox checked with underscore and space    3d. Include Subdirs is NOT checked 4. click on Execute 5. now click the Stop macro button Then with a folder full of untagged but correctly named files, I hit the button for the macro I just created and I get this error: Syntax error, required parameter "IncludeSubdirs" was not found in operation "AutoTag", aborting. I tried selecting "Include Subdirs" while creating the macro as well as selecting the "Include Subdirs" checkbox in the macros window but always get the error when I try to run my macro. What am I doing wrong?? I'm trying to get it working with the GUI first before trying the command-line version. thanks for your help!! Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 24 2004,12:29 You did nothing wrong, on the contrary, I did, and you found the first bug in this beta, congratulations! All other macros except the ones using the Auto Tag tool seem to work fine though, so please play around with these until I fix this bug. Thanks! -------------- Software author and website owner Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 24 2004,14:17 Ok, I just released beta 2, which fixes this problem. Please try it and it should hopefully work fine. -------------- Software author and website owner Back to top

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 24 2004,15:56 Beta2 works great for the type of macros I was trying. Next I will try to do it from the command line and if that works I'll be adding it to my program!! Thanks, this is VERY COOL! Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 24 2004,16:14 Ok, sounds good, please let me know of any potential problems you might stumble upon while using the command-line functionality (or anything else), and I will look into it. -------------- Software author and website owner Back to top

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 26 2004,03:10 Hey there, I think I found another macro bug. I'm using the command-line interface exclusively now. I just created a new macro that does a "Mass set tags/flags" to set the genre as well as an extended tag called "encoded by". When I run this macro from my program using the command-line syntax, I get this error: "Syntax error, unknown property "OtherV2FrameID1" in operation "MassSetTags", aborting." I have a feeling this is because I am setting the "encoded by" tag because when I re-created the macro without the extended tag it then worked. This new functionality (macros and command-line) is AWESOME!!  Thanks!!! Back to top

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 26 2004,04:19 I found something else but this time I am not sure that I'm not doing this incorrectly. I'm trying to implement macro parameters that are used from my 4DOS batch file. I am getting this error when I run from command-line, but it works from the GUI: "Mp3/Tag Studio command-line error: The macro parameter %genreVal% is used by a macro but is not defined on the command-line and has no default value..." I removed the default value definition in the .mtm file when I was always getting the default and never getting the value I am specifying on the command-line. Here is my command-line syntax: call "%mp3ts" -d "%destDir" -macro "setGenreVar" -macroparam genreVal "someGenre" where %mp3ts = full path and mp3ts executable         %destDir = full path to file with .mp3 files I tried putting quotes around "genreVal" but that didn't work either. In the .mtm file are the following: param %genreVal% ..... GenreString=%genreVal% ..... I removed the lines between where you see "....." Can you see what I'm doing wrong? thanks again! Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 26 2004,16:00 First off, thanks for reporting the bug in the mass set tool, I have fixed it now and it will work in the next beta (probably available tonight or tomorrow). Second, about your command-line problem, your mistake is to not include the percentage signs around the variable name in the command-line call. The correct command-line would look like this: call "%mp3ts" -d "%destDir" -macro "setGenreVar" -macroparam %genreVal% "someGenre" I did it this way to keep it consistent and easy to remember for people (i.e. so people don't get confused when you should include the percentage signs in some situations but not in other), but now that I think about it, it is not very good to force people to include these percentage signs on the command-line, because percentage signs have special meaning in some scripts and for environment variables, which might in turn cause problems when people try to call it from scripts and such, so I have now made it possible to do it either way, both with and without the percentage signs. This will also be available in the next beta. Thanks a lot for your reports, please keep them coming! -------------- Software author and website owner Back to top

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 26 2004,16:38 Thanks for the info! I will look forward to the next beta. I feel that I should point out that the help file examples do not show percent signs around the macro parameter names. It's probably fine to leave it as it is though since you're going to change the behavior to match the current documentation. However, you may want to add examples that show it both ways. Here's an example from your help file ----------------------------------------------- Example macro execution, on one directory, specifying two macro parameters: The following command-line will execute the macro called "My Macro" on the directory "c:\My Mp3 Folder" (including all of the subdirectories below it): mp3tag_s.exe -ds "c:\My Mp3 Folder" -macro "My Macro" -macroparam MyParam1 "Some value 1" -macroparam MyParam2 "Some value 2" ----------- help file example end ----------------------------------------------------- As you can see, there are no percent signs around "MyParam1" or "MyParam2". I actually considered adding percent signs, but as you pointed out, I'm using a batch file and a percent sign would cause "%MyParam1%" to be treated as a program variable. I may try adding them anyway but escaping them to see if I can get it working until the next beta is available.       ^%MyParam1^% this should work in 4DOS as long as ^ is defined as the escape char (the default setting) When I re-write my program as a Windows app (C++), the percent signs shouldn't be a problem, however I will still prefer not to use them. They make sense to me in the .mtm file but seem counter-intuitive on the command-line. But that's just me. I like your solution to allow either syntax so those that prefer to use the percent signs (for consistency) can do so. Thanks again!! I'll watch for beta 4 and will let you know here how it goes. Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 26 2004,18:17 Yep, I noticed that mistake in the helpfile too, while checking out your report, so it's already fixed. Thanks for reporting it anyway. I left the example as it is, but instead added explicit info to the section describing the "-macroparam" command-line switch, that either way works fine with the percentage signs. -------------- Software author and website owner Back to top

moid Board Fan Group: Members Posts: 13 Joined: Mar. 2004 Posted: May 26 2004,19:28 Just a quick note to let you know that putting in the percent signs does indeed work. I had to escape them since I'm in a batch file as I described before. Just a little more work to my program and it will be saving me TONS of time over the way I used to do it. I can now tag everything, even when creating gapless mp3 files, including non-standard genre names. The entire process will now be only one step, creating files that I can copy directly to my iPod.   Thanks for making the dream reality!!! Back to top

Magnus Brading Almighty Author Group: Super Administrators Posts: 2751 Joined: Aug. 2002 Posted: May 26 2004,22:41 Hehe, no problem, all I ask in return is that you spread the news to as many people as possible, and keep those bug reports coming. -------------- Software author and website owner Back to top

[ Track this topic :: Email this topic :: Print this topic ]

Brading Software Message Board » Mp3/Tag Studio » Mp3/Tag Studio Support and Bug Reports » need help using simple macro

© 2009 Brading Software Powered by Ikonboard 3.1.1 © 2002 Ikonboard